RowSelectionBehavior Implementation #10831

tianzhao-stripe · 2025-05-20T01:20:16Z

Summary

Made row selection callback available to app
Validate config
Once embeddedPaymentElement selection changes, invoke the internalRowSelectionCallback

Motivation

https://docs.google.com/document/d/1_LyLbnJV0KnHPp739xXUYAFr9bdjRvxp-Mh20Y2ZmWM/edit?tab=t.0
https://jira.corp.stripe.com/browse/MOBILESDK-3453

Testing

TODO

Added tests
Modified tests
Manually verified

Changelog

[ADDED]10831 Added RowSelectionBehavior API to Embedded Payment Element

github-actions · 2025-05-20T01:26:43Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ -2 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.8 MiB │   9.8 MiB │ -2 B │  21.8 MiB │  21.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20679 │ 20679 │ 0 (+0 -0) 
   types │  6500 │  6500 │ 0 (+0 -0) 
 classes │  5264 │  5264 │ 0 (+0 -0) 
 methods │ 31505 │ 31505 │ 0 (+0 -0) 
  fields │ 18220 │ 18220 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0

APK

   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 29.2 KiB │ +2 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │ -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 25.9 KiB │ -1 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.5 KiB │ -2 B │ 130.5 KiB │  0 B │ (total)

jaynewstrom-stripe

This PR contains no tests. Please ensure new functionality is matched with associated tests.

...in/java/com/stripe/android/paymentelement/embedded/content/PaymentOptionDisplayDataHolder.kt

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElementKtx.kt

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt

paymentsheet/src/main/java/com/stripe/android/paymentelement/embedded/manage/ManageNavigator.kt

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt

...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt

jaynewstrom-stripe

I think we need to do a few more things:

Add analytics for what value we have for rowSelectionBehavior
Add a better integration / mock network test for this behavior for at least the happy path of selecting a no form PM, formSheetAction=continue + clicking primary button on the form, selecting a saved PM from the manage screen

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElementKtx.kt

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt

...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt

...com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandlerTest.kt

...om/stripe/android/paymentelement/embedded/content/DefaultEmbeddedConfigurationHandlerTest.kt

.../java/com/stripe/android/paymentelement/embedded/content/DefaultEmbeddedSheetLauncherTest.kt

...sheet/src/test/java/com/stripe/android/paymentelement/embedded/manage/ManageNavigatorTest.kt

paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/PaymentSheetEvent.kt

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElement.kt

...com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandlerTest.kt

...t/src/androidTest/java/com/stripe/android/paymentelement/EmbeddedPaymentElementTestRunner.kt

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt

jaynewstrom-stripe

I think it's worth adding this to the playground as a configuration option, but that can happen as a follow up.

...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt

…ed = false)

CHANGELOG.md

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElement.kt

...a/com/stripe/android/paymentelement/EmbeddedPaymentElementImmediateActionRowSelectionTest.kt

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElement.kt

after fixing saved code bug

tianzhao-stripe changed the base branch from CustomCTA_V1 to master May 20, 2025 17:00

tianzhao-stripe marked this pull request as ready for review May 20, 2025 17:00

tianzhao-stripe requested review from a team as code owners May 20, 2025 17:00

tianzhao-stripe requested review from samer-stripe and jaynewstrom-stripe May 20, 2025 17:00

jaynewstrom-stripe requested changes May 20, 2025

View reviewed changes

tianzhao-stripe changed the title ~~CustomCTA Implementation~~ RowSelectionBehavior Implementation May 20, 2025

jaynewstrom-stripe reviewed May 20, 2025

View reviewed changes

...in/java/com/stripe/android/paymentelement/embedded/content/PaymentOptionDisplayDataHolder.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 20, 2025

View reviewed changes

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElementKtx.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 22, 2025

View reviewed changes

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElementKtx.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 22, 2025

View reviewed changes

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 22, 2025

View reviewed changes

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 22, 2025

View reviewed changes

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 22, 2025

View reviewed changes

paymentsheet/src/main/java/com/stripe/android/paymentelement/embedded/manage/ManageNavigator.kt Outdated Show resolved Hide resolved

tianzhao-stripe mentioned this pull request May 27, 2025

Rename constructor params and Annotating them with DimenRes #10854

Merged

jaynewstrom-stripe reviewed May 28, 2025

View reviewed changes

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 28, 2025

View reviewed changes

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed May 28, 2025

View reviewed changes

...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt Outdated Show resolved Hide resolved

tianzhao-stripe force-pushed the CustomCTA_V1_Impl branch from 20ab4bd to 8b9fde8 Compare May 30, 2025 05:38

tianzhao-stripe requested a review from jaynewstrom-stripe May 30, 2025 05:41

jaynewstrom-stripe reviewed May 30, 2025

View reviewed changes

tianzhao-stripe force-pushed the CustomCTA_V1_Impl branch 2 times, most recently from 9e2f99d to 324db73 Compare June 3, 2025 16:13

jaynewstrom-stripe reviewed Jun 3, 2025

View reviewed changes

jaynewstrom-stripe reviewed Jun 5, 2025

View reviewed changes

...t/src/androidTest/java/com/stripe/android/paymentelement/EmbeddedPaymentElementTestRunner.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed Jun 5, 2025

View reviewed changes

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed Jun 5, 2025

View reviewed changes

...et/src/main/java/com/stripe/android/paymentelement/embedded/content/EmbeddedContentHelper.kt Outdated Show resolved Hide resolved

...ava/com/stripe/android/paymentelement/embedded/EmbeddedRowSelectionImmediateActionHandler.kt Outdated Show resolved Hide resolved

tianzhao-stripe added 11 commits June 6, 2025 12:11

internal rowSelectionBehavior classes

d762164

missing comma

331219b

fun interface invoke

a1d3d97

Update EmbeddedContentHelper.kt

eab674b

Update EmbeddedPaymentElementTestRunner.kt

7175dbf

test use turbine

b0216b0

extract assert code to functions

66b87e0

replace espresso onidle with fetchSemanticsNodes(atLeastOneRootRequir…

62f61c7

…ed = false)

move rowSelectionCalls to testContext

47d0e8d

test updates

77a3855

merge conflicts

0ab7701

tianzhao-stripe force-pushed the CustomCTA_V1_Impl branch from dc02afa to 0ab7701 Compare June 6, 2025 21:06

tianzhao-stripe added 2 commits June 6, 2025 14:17

Merge branch 'master' into CustomCTA_V1_Impl

d59397b

Merge branch 'master' into CustomCTA_V1_Impl

52a1b5a

tianzhao-stripe mentioned this pull request Jun 12, 2025

RowSelectionBehavior playground setting #10946

Merged

3 tasks

jaynewstrom-stripe reviewed Jun 13, 2025

View reviewed changes

tianzhao-stripe added 3 commits June 13, 2025 10:32

update changelog, move update to paymentSheet

14f13dc

private object default

d5e6fc8

updates to rowSelectionTest

f76dea0

jaynewstrom-stripe reviewed Jun 13, 2025

View reviewed changes

...a/com/stripe/android/paymentelement/EmbeddedPaymentElementImmediateActionRowSelectionTest.kt Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed Jun 13, 2025

View reviewed changes

paymentsheet/src/main/java/com/stripe/android/paymentelement/EmbeddedPaymentElement.kt Outdated Show resolved Hide resolved

tianzhao-stripe added 3 commits June 13, 2025 10:58

use only assertNextCardRowSelectionItem

2fce35a

after fixing saved code bug

private class immediateAction

d762eb9

Merge branch 'master' into CustomCTA_V1_Impl

0941ccd

jaynewstrom-stripe previously approved these changes Jun 13, 2025

View reviewed changes

fix test

4ac87d8

tianzhao-stripe dismissed jaynewstrom-stripe’s stale review via 4ac87d8 June 13, 2025 18:45

jaynewstrom-stripe approved these changes Jun 13, 2025

View reviewed changes

tianzhao-stripe merged commit 8678c5e into master Jun 13, 2025
13 checks passed

tianzhao-stripe deleted the CustomCTA_V1_Impl branch June 13, 2025 19:04

RowSelectionBehavior Implementation #10831

RowSelectionBehavior Implementation #10831

Uh oh!

Conversation

tianzhao-stripe commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Testing

Changelog

Uh oh!

github-actions bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tianzhao-stripe commented May 20, 2025 •

edited

Loading

github-actions bot commented May 20, 2025 •

edited

Loading